fix: Introduce PHP 8.5 compatibility for hashCode function #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.5 introduced stricter float-to-int casting that throws an error when a float value is not representable as an integer. The hashCode function's bit shifting operations could produce values exceeding PHP's integer range, causing automatic conversion to float and subsequent casting errors. This fix applies bitwise AND with 0xFFFFFFFF to keep values within 32-bit range and properly converts from unsigned to signed 32-bit integers, preventing float conversion while maintaining consistent hash values. Fixes amplitude#39
ruudk
changed the title
Contributor
Author
zhukaihan
requested changes
Oct 28, 2025
Collaborator
zhukaihan
left a comment
zhukaihan
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR. Left a comment.
Co-authored-by: Peter Zhu <7332407+zhukaihan@users.noreply.github.com>
zhukaihan
approved these changes
Oct 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
## [1.2.5](1.2.4...1.2.5) (2025-10-28) ### Bug Fixes * Introduce PHP 8.5 compatibility for hashCode function ([#38](#38)) ([8f87a6e](8f87a6e))
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.5 will be released next month and this library has an issue with the
hashCodefunction.Fixes #39