Skip to content

Bump esbuild and vitest#1

Closed
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/multi-b4298e4899
Closed

Bump esbuild and vitest#1
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/multi-b4298e4899

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Dec 5, 2025

Bumps esbuild to 0.25.12 and updates ancestor dependency vitest. These dependencies need to be updated together.

Updates esbuild from 0.21.5 to 0.25.12

Release notes

Sourced from esbuild's releases.

v0.25.12

  • Fix a minification regression with CSS media queries (#4315)

    The previous release introduced support for parsing media queries which unintentionally introduced a regression with the removal of duplicate media rules during minification. Specifically the grammar for @media <media-type> and <media-condition-without-or> { ... } was missing an equality check for the <media-condition-without-or> part, so rules with different suffix clauses in this position would incorrectly compare equal and be deduplicated. This release fixes the regression.

  • Update the list of known JavaScript globals (#4310)

    This release updates esbuild's internal list of known JavaScript globals. These are globals that are known to not have side-effects when the property is accessed. For example, accessing the global Array property is considered to be side-effect free but accessing the global scrollY property can trigger a layout, which is a side-effect. This is used by esbuild's tree-shaking to safely remove unused code that is known to be side-effect free. This update adds the following global properties:

    From ES2017:

    • Atomics
    • SharedArrayBuffer

    From ES2020:

    • BigInt64Array
    • BigUint64Array

    From ES2021:

    • FinalizationRegistry
    • WeakRef

    From ES2025:

    • Float16Array
    • Iterator

    Note that this does not indicate that constructing any of these objects is side-effect free, just that accessing the identifier is side-effect free. For example, this now allows esbuild to tree-shake classes that extend from Iterator:

    // This can now be tree-shaken by esbuild:
    class ExampleIterator extends Iterator {}
  • Add support for the new @view-transition CSS rule (#4313)

    With this release, esbuild now has improved support for pretty-printing and minifying the new @view-transition rule (which esbuild was previously unaware of):

    /* Original code */
    @view-transition {
      navigation: auto;
      types: check;
    }
    /* Old output */
    @​view-transition { navigation: auto; types: check; }
    /* New output */
    @​view-transition {
    navigation: auto;
    types: check;

... (truncated)

Changelog

Sourced from esbuild's changelog.

Changelog: 2024

This changelog documents all esbuild versions published in the year 2024 (versions 0.19.12 through 0.24.2).

0.24.2

  • Fix regression with --define and import.meta (#4010, #4012, #4013)

    The previous change in version 0.24.1 to use a more expression-like parser for define values to allow quoted property names introduced a regression that removed the ability to use --define:import.meta=.... Even though import is normally a keyword that can't be used as an identifier, ES modules special-case the import.meta expression to behave like an identifier anyway. This change fixes the regression.

    This fix was contributed by @​sapphi-red.

0.24.1

  • Allow es2024 as a target in tsconfig.json (#4004)

    TypeScript recently added es2024 as a compilation target, so esbuild now supports this in the target field of tsconfig.json files, such as in the following configuration file:

    {
      "compilerOptions": {
        "target": "ES2024"
      }
    }

    As a reminder, the only thing that esbuild uses this field for is determining whether or not to use legacy TypeScript behavior for class fields. You can read more in the documentation.

    This fix was contributed by @​billyjanitsch.

  • Allow automatic semicolon insertion after get/set

    This change fixes a grammar bug in the parser that incorrectly treated the following code as a syntax error:

    class Foo {
      get
      *x() {}
      set
      *y() {}
    }

    The above code will be considered valid starting with this release. This change to esbuild follows a similar change to TypeScript which will allow this syntax starting with TypeScript 5.7.

  • Allow quoted property names in --define and --pure (#4008)

    The define and pure API options now accept identifier expressions containing quoted property names. Previously all identifiers in the identifier expression had to be bare identifiers. This change now makes --define and --pure consistent with --global-name, which already supported quoted property names. For example, the following is now possible:

... (truncated)

Commits
  • 208f539 publish 0.25.12 to npm
  • 5f03afd update release notes
  • 6b2ee78 minify: remove css rules containing empty :is()
  • f361deb add some additional known static methods
  • 07aa646 automatically mark "RegExp.escape()" calls as pure
  • 9039c46 simplify some call expression checks
  • 188944d add some additional known static methods
  • d3c67f9 fix #4310: add Iterator and other known globals
  • 4a51f0b fix: escape dev server breadcrumb hrefs properly (#4316)
  • 26b29ed fix #4315: @media deduplication bug edge case
  • Additional commits viewable in compare view

Updates vitest from 2.1.9 to 4.0.15

Release notes

Sourced from vitest's releases.

v4.0.15

   🚀 Experimental Features

   🐞 Bug Fixes

    View changes on GitHub

v4.0.14

   🚀 Experimental Features

   🐞 Bug Fixes

... (truncated)

Commits
  • eb1abf0 chore: release v4.0.15
  • a68f74e feat(cache): add opt-out on a plugin level, fix internal root cache (#9154)
  • 122ff32 feat(reporters): print import duration breakdown (#9105)
  • 0d2e7e3 fix(browser): run toMatchScreenshot only once when used with `expect.elemen...
  • d57d8bf fix(pool): terminate workers on CTRL+c forceful exits (#9140)
  • bb65e15 fix(reporters): show project in github reporter (#9138)
  • 52b242b chore(deps): update all non-major dependencies (#9133)
  • 4c75492 fix: fix external behavior with deps.optimizer (#9125)
  • a5d98fd refactor(vitest): get current test name from task property (#9120)
  • fd8bd6d fix: use optimizeDeps.rolldownOptions to fix depreated warning + fix `ssr.e...
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for vitest since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

butlersrepos and others added 2 commits December 5, 2025 11:29
Bumps [esbuild](https://github.com/evanw/esbuild) to 0.25.12 and updates ancestor dependency [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). These dependencies need to be updated together.


Updates `esbuild` from 0.21.5 to 0.25.12
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md)
- [Commits](evanw/esbuild@v0.21.5...v0.25.12)

Updates `vitest` from 2.1.9 to 4.0.15
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.15/packages/vitest)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-version: 0.25.12
  dependency-type: indirect
- dependency-name: vitest
  dependency-version: 4.0.15
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Dec 5, 2025
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Mar 9, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/npm_and_yarn/multi-b4298e4899 branch March 9, 2026 23:36
bird-m added a commit that referenced this pull request Apr 15, 2026
Review-panel #1 (Severe): Remove competing browser tab in requires_auth
path. The requires_auth branch opened the backend's redirect URL via
opn() then fell through to performAmplitudeAuth which opened a second
browser tab with mismatched PKCE. Now we skip the backend URL and let
performAmplitudeAuth handle the entire flow. Added TODO to evaluate
using the backend URL in a follow-up.

Review-panel #2 (Critical): Init feature flags in agent/CI paths so
_headlessSignupEnabled can be true. Previously the flag was only set in
the TUI interactive path, making the entire agent/CI headless signup
block unreachable dead code.

Review-panel #3 (Important): Pre-populate HeadlessSignupScreen from CLI
--email/--full-name flags. Auto-submit if both are present.

Review-panel #4 (Important): Redact email in agent NDJSON log output
to match the redaction pattern in headless-signup.ts.

Review-panel #7 (Important): Split fullName into first_name/last_name
on first space before sending to provisioning endpoint.

Review-panel #9 (Nit): Replace non-null assertions on
headlessSignupEmail/headlessSignupFullName with an explicit guard.

Review-panel #10 (Nit): Extract completeSignupTokenExchange into
headless-signup.ts as a shared helper used by both the agent/CI and
TUI code paths, reducing duplication and drift risk.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bird-m bird-m mentioned this pull request Apr 15, 2026
3 tasks
bird-m added a commit that referenced this pull request Apr 16, 2026
`startsWith('[')` matched every log line because the wizard log format
is `[timestamp] msg`. Narrow `[` check to `[{` and `["` so only JSON
arrays are highlighted, not timestamp-prefixed lines.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bird-m added a commit that referenced this pull request Apr 16, 2026
…llName

Disambiguate CLI-provided headless signup fields from the post-auth
userEmail field on WizardSession. The CLI flags (--email, --full-name)
are unchanged.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bird-m added a commit that referenced this pull request Apr 16, 2026
When a user confirms the "already logged in, log out to create a new
account" prompt, also purge ~/.ampli.json. In-memory-only clearing
leaves cached OAuth tokens that the fallback path would silently
re-use because forceFresh is computed from project-local ampli.json,
not ~/.ampli.json. The user told us to log them out — actually do it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kelsonpw added a commit that referenced this pull request Apr 17, 2026
…ting

Sent a CLI DX review. Two verbatim reproductions of the user's feel:

1. The Done screen auto-dismissed after 5s on success, 2s otherwise.
   If the user was mid-read — and the plugin success screen has 4+
   lines including two docs URLs and two commands to run — the screen
   vanished out from under them. That's the "disappears on its own"
   feeling.
   Fix: wait for Enter. `useScreenInput` listens for key.return while
   Phase.Done is active and advances immediately. Keep a long 20s
   fallback timer so fully unattended/CI runs still complete. The
   empty "skipped" case still uses 2s (nothing to read). Show an
   explicit "Press Enter to continue" hint below the success/failure
   block so the affordance is obvious.

2. Dead air during detection when filesystem probes are slow. The
   "Looking for supported AI tools…" line had no animation — users
   don't know if it's hung. Wrap it in a BrailleSpinner.

Doesn't yet address the DX reviewer's #1 concern (a suspected
DissolveTransition re-animation on Pick→Working). The DissolveTransition
in App.tsx is keyed on `store.currentScreen` which doesn't change
during McpScreen's internal phase machine, so that particular theory
doesn't hold up from the code — but the perceived stall may still be
real (plugin install genuinely takes 5–15s on first run for the
marketplace clone). Will dig in with the user on a separate pass if
it persists after these changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kelsonpw added a commit that referenced this pull request Apr 17, 2026
… picker)

Batch of bird-m and Bugbot findings from PR #112:

#1 claudeCodeMode default mismatch (medium, flagged 3×):
  addMCPServerToClientsStep silently defaulted to 'plugin' while
  mcp-installer.ts defaulted to 'mcp'. Non-TUI fallback via bin.ts
  could install the plugin with no user prompt. Aligned both to 'mcp'
  as the safer default — plugin is interactive-only now.

#3 remove flow can't uninstall plugin (medium, flagged 2×):
  getInstalledClients only ever instantiated ClaudeCodeMCPClient.
  After plugin install removes the bare `amplitude` MCP entry,
  isServerInstalled returned false and `wizard mcp remove` silently
  skipped Claude Code. Added an explicit ClaudeCodePluginClient probe
  before falling through to the MCP check.

#4 non-TUI `local` flag ignored for plugin path (low, Bugbot):
  addMCPServerToClientsStep now forces 'mcp' mode whenever
  local=true, matching the TUI's behavior. The plugin hardcodes the
  prod URL and can't serve localhost.

#5 `as unknown as RawMCPClient[]` cast (nit, bird-m):
  resolveClientsForMode returns MCPClient[] directly; the local
  RawMCPClient interface was a holdover. Dropped the cast and removed
  the unused interface — install loop now type-checks against
  MCPClient directly.

#6 older Claude CLIs fail opaquely (nit, bird-m):
  ClaudeCodePluginClient.isClientSupported now probes `claude plugin
  --help` in addition to `--version`. resolveClientsForMode is async
  and checks plugin support before swapping — older CLIs quietly keep
  ClaudeCodeMCPClient instead of failing during `marketplace add`.

#7 single-Claude-Code hid plugin/MCP choice (medium, Bugbot):
  detected.length === 1 routed to Phase.Ask, which doesn't show the
  split picker. Now: if the lone detected tool is Claude Code and no
  escape hatch is set, route to Phase.Pick so the user sees plugin vs
  MCP rows.

#8 resolveSelection misleading default (low, Bugbot):
  wantsPlugin || !wantsMcp ? 'plugin' : 'mcp' returned 'plugin' when
  the user unchecked both Claude Code rows. Simplified to
  wantsPlugin ? 'plugin' : 'mcp' — explicit semantics, still correct
  since downstream guards the Claude-Code-absent case.

#9 Codex Windows detection (low, Bugbot):
  `command -v` is POSIX-only; Windows never matched. Use `where codex`
  on win32, `command -v codex` on POSIX. Take the first line since
  `where` may return multiple paths. Narrowed the bundled-app
  exclusion to macOS only (Conductor-specific).

#10 multi-picker uncheck-all dead code (medium, Bugbot):
  MultiPickerMenu's Enter handler fell back to the focused row when
  selected was empty, so a user who unchecked every pre-selected row
  got one install instead of a skip. Now: if defaultSelected was
  provided, an empty set means deliberate — pass [] through to the
  caller. Also fixed lexicographic index sort → numeric.

#? dev script env var at build-time (low, Bugbot):
  `AMPLITUDE_WIZARD_DEV=1 pnpm build` only scoped the var to the
  build subprocess, not the globally-linked binary. Removed from the
  `dev` script since it was ineffective there — `try` still sets it
  at runtime where it actually works.

Addressed in comment, no code change: #2 non-atomic settings.json
write — already replaced with `claude plugin marketplace add` CLI in
commit 4679fc4. No direct file write remains.

974 tests pass, lint clean, smoke test passes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kelsonpw kelsonpw mentioned this pull request Apr 20, 2026
30 tasks
kelsonpw added a commit that referenced this pull request Apr 26, 2026
Closes #297.

Real user log (run_id 66d9fa51, Sentry #7442894144) showed the wizard
crashing ~40s into the new attempt with:

    CLI stderr: Error in hook callback hook_0: Error: Stream closed
        at m98.sendRequest …
    Tool permission request failed: Error: Stream closed

Root cause: the outer retry loop in `runAgent` calls `signalDone()` and
then `continue`s to the next attempt without telling the SDK its prior
Query iterator is done. The SDK's underlying subprocess remains alive
just long enough for an in-flight tool-use message to fire our
PreToolUse hook callback through a stdio bridge that is mid-teardown.
The bridge fails on `m98.sendRequest`, the SDK converts the failure
into a tool_result with `is_error: true`, and the run dies because the
agent can't recover from a tool-permission failure.

Fix: hoist the SDK `Query` (an `AsyncIterable<unknown>` here, but its
concrete `Query` type extends `AsyncGenerator`) so the catch and
post-stream retry paths can call `.return()` on it before the next
attempt. `.return()` propagates an EOF down the AsyncGenerator
protocol; the SDK closes its stdio cleanly. Errors from `.return()`
itself are expected during teardown and are swallowed via a tiny
`drainPriorResponse` helper.

Defense in depth: also add `'Stream closed'` to the transient error
pattern list. If a Stream closed somehow does still bubble out (e.g.
late SDK cleanup), the catch path treats it as transient and retries
cleanly instead of throwing API_ERROR.

Tests:
- New: drains the prior response iterator before retrying after a
  transient API error — spies on .return() and asserts it fires
  during attempt #1, before query() is invoked for attempt #2.
- New: classifies Stream closed errors as transient and retries — locks
  down the defense-in-depth pattern.
- Existing 119 runAgent tests still green (stall retry, GATEWAY_DOWN
  classification, race-condition handling, legacy text markers, etc.).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kelsonpw added a commit that referenced this pull request Apr 28, 2026
…331)

* fix: gracefully handle late-stage API errors so users see the Outro

Two related fixes for a UX gap surfaced when an agent run hits an API
error AFTER all the meaningful work (events instrumented, dashboard
created, setup report written) has completed.

Symptom: the wizard would call wizardAbort -> getUI().cancel() ->
process.exit(NETWORK_ERROR) before Ink had time to render the next
frame, so the user saw a half-rendered "API error occurred" status
banner and a sudden process death — no MCP install offer, no Slack
prompt, no Outro screen with bug-report hotkeys, and a misleading
network error code in CI even though the project was fully set up.

## Fix #1 — wizardAbort awaits OutroScreen dismissal in TUI mode

- WizardUI.cancel() returns Promise<void> instead of void.
  - InkUI: returns a promise that resolves when the OutroScreen is
    dismissed (keypress / picker action) OR after a 5-minute safety
    timeout. The TUI now actually gets to render the failure state.
  - AgentUI / LoggingUI: resolve immediately. No TUI to render, no
    human to interact.
- WizardStore exposes outroDismissed() / signalOutroDismissed() — a
  one-shot promise that bridges the OutroScreen render loop to
  wizardAbort. Idempotent and pre-resolves correctly when dismissal
  arrives before any awaiter (race-safe).
- OutroScreen non-success keypress handler now calls
  store.signalOutroDismissed() instead of process.exit(0). Lets
  wizardAbort drive the actual exit with the right exit code, run
  analytics shutdown, and flush Sentry — none of which were happening
  before because process.exit(0) jumped the queue.
- wizardAbort awaits getUI().cancel() before process.exit. UI errors
  in the await are caught + ignored so a busted UI can't trap the
  user in a hung process.

## Fix #2 — soft-error path: agent finished, just continue

- New `agentArtifactsLookComplete(session)` predicate checks for the
  dashboard URL on the session. The dashboard MCP create is the last
  thing the agent does in its conclude phase, after events are
  instrumented and the setup report is written; if it succeeded, the
  user's project is in a working state.
- API_ERROR / RATE_LIMIT branch in runAgentWizardBody now splits:
  - artifacts complete -> log a soft-error analytics event, surface
    a non-fatal status banner, fall through to the post-agent steps
    (env upload, MCP, Slack, DataIngestion, Outro). User gets the
    full success experience minus a "late API call failed but your
    setup is complete" warning.
  - artifacts missing -> existing hard-abort path, now extracted into
    `abortOnApiError()` for clarity.

## Tests

- src/ui/tui/__tests__/store.test.ts: outroDismissed resolves on
  signalOutroDismissed, returns the same promise for concurrent
  awaiters, pre-resolves on early dismissal, and is idempotent.
- src/lib/__tests__/agent-runner.test.ts: agentArtifactsLookComplete
  returns true with a real dashboard URL, false with null, false
  with empty string.

Verified: pnpm lint clean (1 pre-existing warning in untouched code),
pnpm test 1660 passing (+7 new tests).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address bugbot findings on wizardAbort sequencing

Two related bugbot findings on PR 331:

1. **Medium: outro-hotkey analytics events were silently dropped.**
   `analytics.shutdown()` ran before `getUI().cancel(...)`, but cancel
   now blocks until the user dismisses the OutroScreen. Any
   `wizardCapture` calls fired during that interaction — `'error outro
   log opened'` (press L), `'error outro bug report written'` (press
   C) — got queued *after* the final flush and dropped on
   `process.exit`. Fix: flip the order to cancel-then-shutdown so
   those events are flushed in the post-outro batch.

2. **High: process hangs on the version-check cancel path.**
   `agent-runner.ts` `runAgentWizard` called `getUI().cancel(...)`
   then `return false` for unsupported framework versions. With
   cancel now async + awaiting outro dismissal, the user dismisses
   the outro but nothing exits — Ink keeps the event loop alive
   indefinitely. The old `process.exit(0)` in OutroScreen used to be
   the de-facto exit for this path; replacing it with
   `signalOutroDismissed()` exposed the hang. Fix: route this path
   through `wizardAbort` (which always exits), and extend
   `wizardAbort` to forward `cancelOptions.docsUrl` so the manual
   setup link still surfaces in the Outro.

Tests:
- New: cancel-before-shutdown ordering, cancelOptions.docsUrl
  forwarding.
- Updated: existing ordering tests flipped to match new sequence;
  cancel-call-arity expectations include the new options arg.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants