fix: detect VitePress and VuePress as JavaScript (Web), not Vue#492
Merged
Conversation
Docs stacks such as VitePress declare `vue` but are not product Vue SPAs. Skip the Vue integration for those packages and allow the JavaScript (Web) detector to match so projects like amplitude-docs classify correctly. Made-with: Cursor
kelsonpw
force-pushed
the
fix/detect-vue-powered-docs-as-javascript-web
branch
2 times, most recently
from
91f2f3e to
91f7964
Compare
Resolve conflicts with the shared javascript-web blocking policy: keep VitePress/VuePress/Slidev exceptions for vue while using the centralized blocker. Extend JavaScript (Web) context so docs/deck stacks get clearer agent guidance, add Slidev parity tests, and retain main's optionalDependencies Vue detection test. Co-authored-by: Cursor <cursoragent@cursor.com>
kelsonpw
force-pushed
the
fix/detect-vue-powered-docs-as-javascript-web
branch
from
91f7964 to
8b55f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vue, which made the wizard treat documentation repos (e.g.amplitude-docs) as Vue apps.isVuePoweredDocsSite()and skip the Vue integration for those stacks.vueas a blocking framework package when a docs stack is present.Test plan
pnpm test src/frameworks/vue/__tests__/vue-wizard-agent.test.ts src/frameworks/javascript-web/__tests__/javascript-web-wizard-agent.test.tsMade with Cursor
Note
Medium Risk
Adjusts framework detection and blocking rules that decide which integration the wizard applies, so misclassification could route users to the wrong setup flow. Scope is limited to Vue vs generic JS-Web detection plus prompt/context text updates and tests.
Overview
Ensures Vue-powered docs/presentation stacks (VitePress/VuePress/Slidev) are not detected as
Vueapps and instead fall through to theJavaScript (Web)wizard.Adds a shared
isVuePoweredDocsSite()helper and updatesjavascriptWebBlockedByFrameworkPackagesovueno longer blocks JS-Web when one of these docs packages is present; the JS-Web wizard also now surfaces this classification in its additional context line.Extends unit tests to cover Slidev alongside VitePress for both the Vue detector (ignore) and JS-Web detector (match).
Reviewed by Cursor Bugbot for commit 8b55f1e. Bugbot is set up for automated code reviews on this repo. Configure here.