Skip to content

Adding “Web Development with AMP” Courses to amp.dev#1595

Closed
mandarini wants to merge 116 commits intoampproject:futurefrom
mandarini:future
Closed

Adding “Web Development with AMP” Courses to amp.dev#1595
mandarini wants to merge 116 commits intoampproject:futurefrom
mandarini:future

Conversation

@mandarini
Copy link
Copy Markdown
Collaborator

@mandarini mandarini commented Mar 20, 2019

We’re developers working with Ben Morss (@morsssss ) to develop content for the amp.dev site. We’re adding the “Web Development with AMP” series which is comprised of three courses (Beginner, Intermediate, and Advanced). We know that the AMP team is still deciding where these courses should reside in the navigation, but the purpose of this PR is to start the review of the content itself and make any necessary changes.

@matthiasrohmer
Copy link
Copy Markdown
Collaborator

Not sure if this is known to all, therefore thought I'd share it again: plans are that Documentation is not clickable anymore but will always open the flyout and will get a new item "Get Started" which will lead to what's currently the Guides and Tutorial landing pages. This will then be replaced by an overview page similar to the one the components and examples have.

Therefore in my opinion adding another "Courses" item to the flyout seems like a good idea. This could then lead to a dedicated Courses landing page with it's own sidebar. 🙂

@pbakaus
Copy link
Copy Markdown
Collaborator

pbakaus commented Apr 4, 2019

+1 to what @matthiasrohmer said!

@morsssss
Copy link
Copy Markdown
Collaborator

morsssss commented Apr 8, 2019

Sounds great!

If so, it looks like I can proceed more or less in the way I proposed... adding a new element to the flyout in the Blueprint, moving all the files to a new directory, creating the landing page, etc. And I'll look at how to create the sidebar 😃

Is that right?

@pbakaus
Copy link
Copy Markdown
Collaborator

pbakaus commented Apr 8, 2019

Sounds about right to me!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 9, 2019
@matthiasrohmer
Copy link
Copy Markdown
Collaborator

@morsssss, feel free to reach out on Slack if I can support with setting things up 🙂

morsssss and others added 5 commits April 9, 2019 18:52
Started creating landing page.
- Consistent code font usage throughout the document
- Updated links to point to amp.dev
- Updated images where needed
- Revamped the social share exercise
- Fixed various typos/removed dead content
@morsssss
Copy link
Copy Markdown
Collaborator

This has now been moved to a feature branch on the main repo....

@matthiasrohmer
Copy link
Copy Markdown
Collaborator

Closed in favor of #1887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants