Skip to content

Implement pixi recommendation mapping#4394

Merged
matthiasrohmer merged 9 commits intofuturefrom
feature/pixi-recommendations-impl
Aug 31, 2020
Merged

Implement pixi recommendation mapping#4394
matthiasrohmer merged 9 commits intofuturefrom
feature/pixi-recommendations-impl

Conversation

@tharders
Copy link
Copy Markdown
Collaborator

The recommendation mapping currently does not use the page experience result.

There is a known issue that html entities in the body of a recommendation are not shown as the character but as the entity character sequence.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 28, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 28, 2020
@tharders tharders mentioned this pull request Aug 28, 2020
@tharders tharders added cla: yes and removed cla: no labels Aug 28, 2020
@google-cla google-cla bot removed the cla: yes label Aug 28, 2020
@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 28, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@robinvanopstal
Copy link
Copy Markdown
Contributor

@googlebot I consent.

@google-cla google-cla bot added the cla: yes label Aug 28, 2020
@matthiasrohmer matthiasrohmer merged commit 125d8a5 into future Aug 31, 2020
@matthiasrohmer matthiasrohmer deleted the feature/pixi-recommendations-impl branch August 31, 2020 07:26
continue;
}
render(recommendationIds) {
console.log('recommendationIds', recommendationIds);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove in future PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants