Implement pixi checks with page experience audit data#4427
Merged
Conversation
caroqliu
approved these changes
Sep 2, 2020
Collaborator
caroqliu
left a comment
caroqliu
left a comment
There was a problem hiding this comment.
noResourceIssues -- I prefer positive boolean names if possible, what about resourcesLoadable?
| ]); | ||
|
|
||
| const result = []; | ||
| const result = [...fixedRecommendations]; |
Collaborator
There was a problem hiding this comment.
I prefer intrusive interstitials recommendation to be last if possible, since a developer who runs their page several times (while acting on recommendations) will only find the manual step helpful the first time.
Collaborator
Author
There was a problem hiding this comment.
Good point.
I think we should add an order property to the recommendation markdown files and then sort them before rendering.
That would be better than having an order here.
We will do this in a separate PR.
robinvanopstal
added a commit
that referenced
this pull request
Sep 3, 2020
* future: Rename noResourceIssues to resourcesLoadable (#4432) Implement checks with page experience audit data (#4427) make negative portion of pixi performance scale solid (#4426) ♻️ Remove unused catch (#4425) Pixi status banner rules (#4421) Update CSS for teaser (#4423) Update pixi upgrade-amp-optimizer recommendation text (#4422) # Conflicts: # frontend/scss/components/atoms/pixi-scale.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommendation mapping is refactored to be more clear and also mapps the new checks.
Changed the "resourceIssues" result to "noResourceIssues" so that all basic checks return true if all is fine.