Skip to content

Pixi: Tooltip aria-expanded value should default to "false"#4688

Merged
matthiasrohmer merged 1 commit intoampproject:futurefrom
caroqliu:tooltip-a11y-default-value
Sep 25, 2020
Merged

Pixi: Tooltip aria-expanded value should default to "false"#4688
matthiasrohmer merged 1 commit intoampproject:futurefrom
caroqliu:tooltip-a11y-default-value

Conversation

@caroqliu
Copy link
Copy Markdown
Collaborator

Prior to this change it has been defaulting to "null"

@matthiasrohmer matthiasrohmer merged commit d691b73 into ampproject:future Sep 25, 2020
robinvanopstal added a commit that referenced this pull request Sep 25, 2020
* future:
  Pixi: Link to a prefilled GitHub issue for "File a GitHub issue" (#4684)
  Set default value to "false" when variable is null (#4688)

# Conflicts:
#	pixi/src/ui/report/CoreWebVitalsReportView.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants