♿️ Set aria expanded on recommendation header#4700
Merged
robinvanopstal merged 1 commit intofuturefrom Sep 25, 2020
Merged
Conversation
robinvanopstal
requested review from
caroqliu and
matthiasrohmer
and removed request for
caroqliu
matthiasrohmer
approved these changes
Sep 25, 2020
robinvanopstal
added a commit
that referenced
this pull request
Sep 25, 2020
* future: ♿️ Set aria expanded on recommendation header (#4700)
caroqliu
reviewed
Sep 25, 2020
| @@ -202,6 +202,8 @@ export default class RecommendationsView { | |||
| recommendation.classList.remove('expanded'); | |||
| recommendation.setAttribute('aria-expanded', 'false'); | |||
Collaborator
There was a problem hiding this comment.
Want it for this one as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #4687