Skip to content

Add initial CI with prettier check, package.json#8

Merged
estherkim merged 4 commits intoampproject:mainfrom
estherkim:init
Feb 8, 2022
Merged

Add initial CI with prettier check, package.json#8
estherkim merged 4 commits intoampproject:mainfrom
estherkim:init

Conversation

@estherkim
Copy link
Copy Markdown
Collaborator

No description provided.

@estherkim estherkim requested a review from rileyajones February 8, 2022 16:54
@estherkim estherkim mentioned this pull request Feb 8, 2022
11 tasks
@estherkim estherkim requested a review from samouri February 8, 2022 16:57
branches:
- main

workflow_dispatch:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this line? it is bare which I find suspicious.

Copy link
Copy Markdown

@mdmower mdmower Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's legit. It allows a GitHub workflow to be triggered manually and that workflow does not require any inputs.

Sorry, don't mean to invade the review. Mostly just popping in to say hi 👋 since it's been a while. Cheers all!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha. it's to trigger manually

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops just saw your comment @mdmower. long time, hi!!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt! Thanks for the info & hope all is well. Feel free to drive by with helpful comments whenever you like 😄

@estherkim estherkim merged commit 419a70a into ampproject:main Feb 8, 2022
@estherkim estherkim deleted the init branch February 8, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants