-
Notifications
You must be signed in to change notification settings - Fork 22
CNewLightPoint methodmap, item lights fixes #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added methodmap CNewLightPoint for NewLight_Point. It is not full, something may will not work (not everything tested). - Added newlight_point for `item_ammo_canister` entity. Seems to work with SDKHook_SetTransmit properly. - Used 100 value battery light range (see one of the comments for the reasons).
ampreeT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a Linux dedicated server and works as described. Fix the CI errors and it should be good. Thank you!
It's strange, because I haven't received bool and dif int issues on my side (new compiler rules?). |
CI is a bit more strict. Pass pBatteryLight.SetTexLight(true);
pBatteryLight.SetEnabled(true);
pCanisterLight.SetEnabled(true); |
|
Replaced with int cuz you can set any values you want (4 bit val). |
I would say undo that commit and pass |
Alright, done. |
|
Hoh, noticed. |
- Hope didn't missed anything now.
ampreeT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you @MyGamepedia!
|
Gonna do more fixes in the future. |
item_ammo_canisterentity. Seems to work with SDKHook_SetTransmit properly.