Skip to content

Conversation

@MyGamepedia
Copy link
Contributor

  • Added methodmap CNewLightPoint for NewLight_Point. It is not full, something may will not work (not everything tested).
  • Added newlight_point for item_ammo_canister entity. Seems to work with SDKHook_SetTransmit properly.
  • Used 100 value battery light range (see one of the comments for the reasons).

- Added methodmap CNewLightPoint for NewLight_Point. It is not full, something may will not work (not everything tested).
- Added newlight_point for `item_ammo_canister` entity. Seems to work with SDKHook_SetTransmit properly.
- Used 100 value battery light range (see one of the comments for the reasons).
Copy link
Owner

@ampreeT ampreeT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Linux dedicated server and works as described. Fix the CI errors and it should be good. Thank you!

@MyGamepedia
Copy link
Contributor Author

Tested on a Linux dedicated server and works as described. Fix the CI errors and it should be good. Thank you!

It's strange, because I haven't received bool and dif int issues on my side (new compiler rules?).

@ampreeT
Copy link
Owner

ampreeT commented Oct 20, 2025

Tested on a Linux dedicated server and works as described. Fix the CI errors and it should be good. Thank you!

It's strange, because I haven't received bool and dif int issues on my side (new compiler rules?).

CI is a bit more strict. Pass true instead of 1 and it should compile for all three of those errors :)

pBatteryLight.SetTexLight(true);

pBatteryLight.SetEnabled(true);

pCanisterLight.SetEnabled(true);

@MyGamepedia
Copy link
Contributor Author

Replaced with int cuz you can set any values you want (4 bit val).

@MyGamepedia MyGamepedia requested a review from ampreeT October 20, 2025 00:46
@ampreeT
Copy link
Owner

ampreeT commented Oct 20, 2025

Replaced with int cuz you can set any values you want (4 bit val).

I would say undo that commit and pass true to those arguments instead to fix the errors. Although with GetEntProp returns a int from a scripting side, we convert it to a bool because the engine considers it as such. Helps with misusage of expected values and types

@MyGamepedia
Copy link
Contributor Author

Replaced with int cuz you can set any values you want (4 bit val).

I would say undo that commit and pass true to those arguments instead to fix the errors. Although with GetEntProp returns a int from a scripting side, we convert it to a bool because the engine considers it as such. Helps with misusage of expected values and types

Alright, done.

@MyGamepedia
Copy link
Contributor Author

Hoh, noticed.

- Hope didn't missed anything now.
Copy link
Owner

@ampreeT ampreeT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @MyGamepedia!

@ampreeT ampreeT merged commit 210f979 into ampreeT:master Oct 20, 2025
2 checks passed
@MyGamepedia
Copy link
Contributor Author

Gonna do more fixes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants