Skip to content

feat(vic3): Validate modifier flow with add_modifier#263

Merged
amtep merged 3 commits into
amtep:mainfrom
BrknRobot:vic3_add_modifier_checks
Aug 7, 2025
Merged

feat(vic3): Validate modifier flow with add_modifier#263
amtep merged 3 commits into
amtep:mainfrom
BrknRobot:vic3_add_modifier_checks

Conversation

@BrknRobot
Copy link
Copy Markdown
Contributor

@BrknRobot BrknRobot commented Aug 6, 2025

warning(modifiers): `interest_group_ig_industrialists_pol_str_mult` is a modifier for interest group and will not flow from state scope
   --> [Vic3] common/static_modifiers/content_4_modifiers.txt
403 |     interest_group_ig_industrialists_pol_str_mult = 0.05
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   --> [Vic3] events/russo_chinese_events.txt
379 |              add_modifier = modifier_vladivostok_civilian
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <-- from this temporary modifier
332 |         random_state = {
    |         ^^^^^^^^^^^^ <-- scope was deduced from `random_state` here
    = Info: valid modifiers are for building, state, goods
    = Wiki: https://vic3.paradoxwikis.com/Modifier_types#Modifier_type_flow

untidy(modifiers): script only modifier does not use a valid prefix
    --> [Vic3] common/modifier_type_definitions/00_modifier_types.txt
2800 | dummy_modifier_type={
     | ^^^^^^^^^^^^^^^^^^^
     = Info: consider using a prefix to ensure the modifier flows to the intended scope
     = Wiki: https://vic3.paradoxwikis.com/Modifier_types#Modifier_type_flow

@BrknRobot BrknRobot mentioned this pull request Aug 6, 2025
8 tasks
@BrknRobot BrknRobot force-pushed the vic3_add_modifier_checks branch 2 times, most recently from e75e295 to bf71998 Compare August 7, 2025 04:48
@BrknRobot BrknRobot force-pushed the vic3_add_modifier_checks branch from bf71998 to 372acf2 Compare August 7, 2025 05:06
Comment thread src/report/writer.rs
log_line_info(errors, output, indentation, info);
}

// Log the info line, if one exists.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error in comment :)

Comment thread src/report/writer.rs
_ = writeln!(output, "{}", ANSIStrings(line_info));
}

/// Log the optional info line that is part of the overall report.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error in comment

@amtep amtep merged commit d55ab25 into amtep:main Aug 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants