Fix version detection to work with older gmakes#1231
Merged
LourensVeen merged 1 commit intoamusecode:mainfrom Mar 12, 2026
Merged
Fix version detection to work with older gmakes#1231LourensVeen merged 1 commit intoamusecode:mainfrom
LourensVeen merged 1 commit intoamusecode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested this with gmake 4.4.1, 4.3, 4.2.1, 4.2, and even 3.81, and could reproduce the problem on versions before 4.3. With this fix applied, it works with all of the above versions, although building with gmake 3.81 doesn't work for unrelated reasons. That's fine, it's extremely old and macOS users can install a newer make with all the other dependencies.
Fixes #1188.