Skip to content

Add plotting submodule#735

Merged
rieder merged 3 commits intoamusecode:mainfrom
rieder:plotting
Jul 7, 2021
Merged

Add plotting submodule#735
rieder merged 3 commits intoamusecode:mainfrom
rieder:plotting

Conversation

@rieder
Copy link
Copy Markdown
Member

@rieder rieder commented Feb 21, 2021

  • Rename plot.py to plot/__init__.py so it works the same way
  • Create a logical place to add plotting modules (TBA)

@rieder rieder requested a review from ipelupessy February 21, 2021 17:51
@rieder
Copy link
Copy Markdown
Member Author

rieder commented Feb 21, 2021

@ipelupessy a very minimal change but I think it would be a good one - with this change we could add plotting scripts in a more logical location than 'ext'.

@ipelupessy
Copy link
Copy Markdown
Member

yea, though better still if plot.py -> plot/_plot.py (or plotbase or something) and init.py just a from _plot import *
... in any case, these plotting routines are somewhat deprecated...

@rieder
Copy link
Copy Markdown
Member Author

rieder commented Feb 21, 2021

yea, though better still if plot.py -> plot/_plot.py (or plotbase or something) and init.py just a from _plot import *
... in any case, these plotting routines are somewhat deprecated...

sure, more work to be done and init should be cleaner by importing from elsewhere (_plot sounds ok). But for backward compatibility, this completely works and allows for incremental updates.

And yes, I guess plot.py is somewhat outdated, but still I can see a use. After all, it's best to avoid requiring the units to be specified multiple times (for plot data and again for axes) if we can...

@rieder rieder merged commit 2820692 into amusecode:main Jul 7, 2021
@rieder rieder deleted the plotting branch July 7, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants