Skip to content

Lapack detect#749

Merged
ipelupessy merged 16 commits intoamusecode:mainfrom
ipelupessy:lapack_detect
Dec 1, 2021
Merged

Lapack detect#749
ipelupessy merged 16 commits intoamusecode:mainfrom
ipelupessy:lapack_detect

Conversation

@ipelupessy
Copy link
Copy Markdown
Member

it seems to change (too) much..

@ipelupessy
Copy link
Copy Markdown
Member Author

e.g. the shtool needs to be there (or install-sh), but is not used..

@ipelupessy
Copy link
Copy Markdown
Member Author

I am not sure about this last thing; the Makefile can also be used to build target that do not depend on configure having run (like releases) but I think most of these are broken and should maybe not be in the Makefile to begin with...(so we can clean this up)

@ipelupessy
Copy link
Copy Markdown
Member Author

@rieder comments?

@ipelupessy
Copy link
Copy Markdown
Member Author

I think this can be merged..

@ipelupessy
Copy link
Copy Markdown
Member Author

@rieder do you think this is ok? its mostly harmless but for the Makefile: it is now generated after configure, which makes sense but means that you cannot "do things" before that...

@rieder
Copy link
Copy Markdown
Member

rieder commented Nov 23, 2021

Yeah this is fine

Copy link
Copy Markdown
Member

@rieder rieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, maybe needs re-running autoconf etc. just before / just after merging

@ipelupessy
Copy link
Copy Markdown
Member Author

the last merge looked a bit funny, hope I didn't mess up...

@rieder
Copy link
Copy Markdown
Member

rieder commented Nov 29, 2021

the last merge looked a bit funny, hope I didn't mess up...

looks ok to me

@rieder
Copy link
Copy Markdown
Member

rieder commented Nov 29, 2021

where does config.guess originate?

@rieder
Copy link
Copy Markdown
Member

rieder commented Nov 29, 2021

and config.sub?

@ipelupessy
Copy link
Copy Markdown
Member Author

if i am not mistaken (it should match):
https://git.savannah.gnu.org/cgit/config.git/plain/config.sub
(mentioned in the file)
but it could also have been copied from some other project

@rieder
Copy link
Copy Markdown
Member

rieder commented Nov 29, 2021

I see. Slightly worried about license issues here (I'm no expert at that) but I guess it may be ok.

@rieder
Copy link
Copy Markdown
Member

rieder commented Dec 1, 2021

ok to merge

@ipelupessy ipelupessy merged commit a1d8168 into amusecode:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants