Allow overriding the close_fds option to Popen.#803
Merged
ipelupessy merged 1 commit intoamusecode:mainfrom Nov 2, 2021
Merged
Allow overriding the close_fds option to Popen.#803ipelupessy merged 1 commit intoamusecode:mainfrom
ipelupessy merged 1 commit intoamusecode:mainfrom
Conversation
When running pytest on macOS, the close_fds options breaks, causing subprocess to always exit with error codes. So add an option to disable close_fds when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running pytest on macOS, the close_fds options breaks, causing subprocess
to always exit with error codes. So add an option to disable close_fds when
needed.