feat: pass through the LLM ID (#121) #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a migration from brainType to llmId in the PersonaConfig interface, maintaining backward compatibility during the transition period.
- Replaced
brainTypewith optionalllmIdin the CustomPersonaConfig interface - Added deprecation warnings when
brainTypeis used in API calls - Updated documentation to reflect the new field and deprecation notice
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/PersonaConfig.ts | Updates interface to use llmId instead of brainType and modifies type guard to check for both fields |
| src/modules/CoreApiRestClient.ts | Adds deprecation warnings when brainType is detected in persona configurations |
| README.md | Updates documentation with deprecation notice and example using new llmId field |
Comment on lines
+51
to
+55
| if (personaConfig && 'brainType' in personaConfig) { | ||
| console.warn( | ||
| 'Warning: brainType is deprecated and will be removed in a future version. Please use llmId instead.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
The deprecation warning logic is duplicated in two methods. Consider extracting this into a private method to avoid code duplication.
Suggested change
| if (personaConfig && 'brainType' in personaConfig) { | |
| console.warn( | |
| 'Warning: brainType is deprecated and will be removed in a future version. Please use llmId instead.', | |
| ); | |
| } | |
| this._logDeprecationWarningForBrainType(personaConfig); |
ao-anam
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.