-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add gateway config option for http and ws requests #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9cb375 to
7cff06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 13 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/modules/EngineApiRestClient.ts">
<violation number="1" location="src/modules/EngineApiRestClient.ts:25">
The proxy request logic is duplicated between `EngineApiRestClient` and `CoreApiRestClient`. This violates the DRY principle and should be extracted into a single, shared utility function to prevent inconsistencies and improve maintainability.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Summary by cubic
Adds an optional proxy config to route REST and WebSocket signalling through a custom proxy, with validation and forwarding metadata.