Skip to content

fix: do not match {}, only ${}#4

Merged
anandjoshi91 merged 1 commit into
anandjoshi91:masterfrom
aturetta:master
Feb 12, 2023
Merged

fix: do not match {}, only ${}#4
anandjoshi91 merged 1 commit into
anandjoshi91:masterfrom
aturetta:master

Conversation

@aturetta
Copy link
Copy Markdown
Contributor

Pull request #2 was right in principle, but contained a syntax error ($ must be escaped in a RE)

if you add the following line to your test file, you can see what is the effect with or without this patch

file-format-template = /data/system/{os}/object/{obj-id}/

Copy link
Copy Markdown
Owner

@anandjoshi91 anandjoshi91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

LGTM

@anandjoshi91 anandjoshi91 merged commit 6e43b74 into anandjoshi91:master Feb 12, 2023
@anandjoshi91
Copy link
Copy Markdown
Owner

anandjoshi91 commented Feb 12, 2023

Fix applied to the latest release

pip install property==2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants