Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses build failures of the cortexadb-py bindings on Python 3.14 by configuring Cargo to set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1, which suppresses PyO3’s maximum-supported-Python version check.
Changes:
- Add a workspace-level
.cargo/config.tomlthat setsPYO3_USE_ABI3_FORWARD_COMPATIBILITY = "1"for all Cargo builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| [env] | ||
| PYO3_USE_ABI3_FORWARD_COMPATIBILITY = "1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The core problem was that the cortexadb-py Python bindings use a Rust crate called PyO3 (specifically version 0.24.2) to bridge between Rust and Python. PyO3 has strict version compatibility checks. Version 0.24.2 officially only supports up to Python 3.13. When I tried to build the project on Python 3.14, PyO3's built-in compiler script intentionally crashed, stating:
error: the configured Python interpreter version (3.14) is newer than PyO3's maximum supported version (3.13)By creating the .cargo/config.toml file with PYO3_USE_ABI3_FORWARD_COMPATIBILITY="1", I explicitly instructed the Rust compiler to suppress this check and build the bindings using Python's stable ABI (Application Binary Interface).