Add ismulticast(::IPv4) function #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancapdev
reviewed
Jul 29, 2024
| @test length(ipp.payload) == 48 | ||
| end | ||
|
|
||
| @testset "ismulticast" begin |
Owner
There was a problem hiding this comment.
Why do we construct a whole packet to test a function that operators on IP?
Contributor
Author
There was a problem hiding this comment.
True, this is wasteful of cognitive resources. I'll change this to a simpler test.
Contributor
Author
There was a problem hiding this comment.
Updated with new tests now.
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
green-nsk
reviewed
Jul 29, 2024
Co-authored-by: Sergey Fokin <green.nsk@gmail.com>
klf-gs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function to check if an IPv4 address is within the IANA multicast address range.