Retrieve and recompute FCS values #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancapdev
reviewed
Jul 18, 2024
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
ghost
commented
Jul 18, 2024
ancapdev
reviewed
Jul 18, 2024
Owner
ancapdev
left a comment
ancapdev
left a comment
There was a problem hiding this comment.
I know we put the utility to scan a full pcap for FCS presence in here before, but I'm starting to think it doesn't belong. This is really an ethernet level property, and would be better added to https://github.com/ancapdev/NetworkProtocols.jl/blob/master/src/ethernet.jl
green-nsk
reviewed
Jul 18, 2024
Co-authored-by: Sergey Fokin <green.nsk@gmail.com>
ancapdev
reviewed
Jul 18, 2024
ancapdev
approved these changes
Jul 18, 2024
Owner
|
Looks good, shall I merge? |
Author
|
Yep, I think it's good |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows checking for corrupt FCS values.
Not ideal since there's no way to be sure if an FCS actually already exists or not.