FCS detection improvements #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return `nothing` when detection was inconclusive * Keep checking packets until conclusion is reached, or EOF is reached * Optionally compare computed FCS for extra certainty (on by default)
ancapdev
reviewed
Sep 30, 2024
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
green-nsk
reviewed
Sep 30, 2024
Co-authored-by: Sergey Fokin <green.nsk@gmail.com>
ancapdev
reviewed
Sep 30, 2024
Consistency Co-authored-by: Christian Rorvik <christian.rorvik@gmail.com>
klf-gs
force-pushed
the
fcs-detection-improvements
branch
from
3ba166d to
bcd2749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some enhancements to the PCAP FCS detection heuristic:
nothingwhen detection was inconclusive