Add UnixTime parsing from string #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossviljoen
force-pushed
the
rv/parse-unixtime
branch
from
fbf5b22 to
aa8f0b5
Compare
ancapdev
approved these changes
Jan 28, 2025
Owner
ancapdev
left a comment
ancapdev
left a comment
There was a problem hiding this comment.
Yeah the reason I couldn't see how to support dataformat without extending it somehow for the nanosecond part. If we only care about roundtrip to string, then this suffices (what's the use case there?)
Collaborator
Author
|
It's sometimes useful to be able to send strings to/from javascript I also don't have merge rights here, so you'll have to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors the standard Dates API where you can do:
DateTime(string(now()))