Makie extension #12
Merged
Makie extension #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancapdev
reviewed
Mar 25, 2025
Owner
ancapdev
left a comment
ancapdev
left a comment
There was a problem hiding this comment.
Could you bump the version as well, so I can merge and trigger the release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for plotting UnixTime axes in Makie.
As far as I can tell, Makie plots everything as
Float64, which will lose precision when plotting large timestamps. So, the conversion implemented here uses an offset from the last plotted UnixTime, meaning that plotting a single day should have full precision. Plotting multiple days will still inevitably lose precision further back in time.