Skip to content

Update MakieExt compat #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Update MakieExt compat #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30130b0
update Makie compat
rossviljoen Jul 14, 2025
f90f253
MakieCore no longer exists
rossviljoen Jul 14, 2025
4836243
Bump patch version
rossviljoen Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "UnixTimes"
uuid = "ab1a18e7-b408-4913-896c-624bb82ed7f4"
authors = ["Christian Rorvik <christian.rorvik@gmail.com>"]
version = "1.7.0"
version = "1.7.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand All @@ -18,7 +18,7 @@ UnixTimesStructTypesExt = "StructTypes"
UnixTimesTimeZonesExt = "TimeZones"

[compat]
Makie = "0.22"
Makie = "0.22, 0.23, 0.24"
Observables = "0.5"
TimeZones = "1"
julia = "1.9"
Expand Down
2 changes: 1 addition & 1 deletion ext/UnixTimesMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ end

Makie.needs_tick_update_observable(conversion::UnixTimeConversion) = nothing

Makie.MakieCore.should_dim_convert(::Type{UnixTime}) = true
Makie.should_dim_convert(::Type{UnixTime}) = true
Copy link
Owner

@ancapdev ancapdev Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work with 0.22?

Copy link
Collaborator Author

@rossviljoen rossviljoen Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it prints a warning but still works


Makie.create_dim_conversion(::Type{UnixTime}) = UnixTimeConversion()

Expand Down