Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things for the MakieExt:
custom_epochused for the conversion toUNIX_EPOCH. This is because the current behaviour (picking the custom epoch to be the last plotted point in the axis) causes multiple axes in the same figure to be misaligned when they have different epochs. It is still possible to set a custom epoch for higher precision on recent dates with:(Unfortunately, constructing the UnixTimeConversion directly to pass to the axis requires the rather ugly
Base.get_extension(UnixTimes, :UnixTimesMakieExt).UnixTimeConversion, as it isn't exported by UnixTimes.)Tested on
Makie@{0.22, 0.23, 0.24}@JoaoAparicio