Add ethereum networks#23
Closed
andrestielau wants to merge 10 commits into
Closed
Conversation
- Added a new member `visualsign-ethereum` to the workspace in `Cargo.toml`. - Created a `.gitignore` file for the `visualsign-ethereum` directory. - Introduced `Cargo.toml` for the `visualsign-ethereum` crate with necessary dependencies. - Implemented `EthereumTransactionWrapper` and `EthereumVisualSignConverter` to handle Ethereum transactions. - Added functions to convert Ethereum transactions to VisualSign payloads and parse ERC-20 transfers. - Included unit tests for various transaction scenarios, including basic transactions, transactions with input data, and ERC-20 transfers. - Registered the new Ethereum transaction converter in the transaction converter registry.
…rameters and removing ERC-20 transfer logic
- Implemented a function to trim trailing zeros from formatted ether values. - Enhanced the `convert_to_visual_sign_payload` function to extract and use the correct chain name based on the transaction's chain ID. - Added a new end-to-end test for parsing Ethereum native transfers, ensuring the parsed transaction includes all expected fields and values.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I making this PR?
To include the correct network in the visual signing
To remove trailing 0 when amount contains fraction
What am I changing?
TODO: add proper description
How do I know it works as designed? Which tests exercise this code?
Added e2e test
Stacked on top of #16