chore(skill): refresh solana-add-idl for post-#228 VisualizerContext API#281
Open
shahan-khatchadourian-anchorage wants to merge 1 commit into
Conversation
The skill scaffolds new IDL-based Solana visualizer presets. Two updates: - Replace the broken `squads_multisig` template reference (preset doesn't exist in this repo) with `dflow_aggregator`, which is a real working example of the post-#228 wire-data pattern. - Add explicit guidance for the new accessor pattern at the top of `visualize_tx_commands`: `context.resolve_program_id()?` / `context.resolve_accounts()?` / `context.data()`. These replace the removed `context.current_instruction()` and surface unresolved indices with precise error messages. - Update the "Required imports" list to match real preset code (BTreeMap for deterministic named-accounts ordering, AccountMeta, OnceLock). - Drop the redundant `Some(hex::encode(...))` second arg in `create_raw_data_field` calls — the helper falls back to the same lowercase hex by default. - Verify step now exercises both feature configs (diagnostics on/off) so newly scaffolded presets work for parser_cli and parser_app alike. Stacked on top of #255.
8 tasks
Copilot started reviewing on behalf of
shahan-khatchadourian-anchorage
May 7, 2026 12:08
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the solana-add-idl Claude skill documentation so newly scaffolded Solana IDL-based presets match the post-#228/#255 VisualizerContext wire-data API and compile under both diagnostics feature configurations.
Changes:
- Switches the recommended template preset from the nonexistent
squads_multisigtodflow_aggregatorand adds guidance for the wire-data accessor pattern (resolve_program_id/resolve_accounts/data). - Refreshes the “required imports” list to align with current preset implementations (e.g.,
BTreeMap,AccountMeta,OnceLock) and documents deterministic named-account ordering. - Expands the verify commands to run clippy/tests with diagnostics both enabled and disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `use` statements at top of module, never inside functions | ||
| - Inline format strings: `format!("{variable}")` not `format!("{}", variable)` | ||
| - Use `create_text_field` and `create_raw_data_field` from `visualsign::field_builders` — never construct field structs directly | ||
| - For raw-data fields, pass `None` as the second arg of `create_raw_data_field` — the helper falls back to lowercase byte-by-byte hex; `Some(hex::encode(data))` is redundant |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #255. Refreshes the
solana-add-idlscaffolding skill so newly-generated presets compile against the wire-dataVisualizerContextintroduced in #255.Changes
squads_multisigtemplate reference (preset doesn't exist in this repo) withdflow_aggregator, a real working example of the post-feat: attested transaction lint diagnostics in SignablePayload #228 pattern.visualize_tx_commands:context.resolve_program_id()?/context.resolve_accounts()?/context.data(). These replace the removedcontext.current_instruction()and surface unresolved indices with precise error messages.BTreeMapfor deterministic named-accounts ordering,AccountMeta,OnceLock).Some(hex::encode(...))second arg increate_raw_data_fieldcalls — the helper falls back to the same lowercase hex by default.Test plan
cargo fmt --check,make lintclean🤖 Generated with Claude Code