Avoid installing across filesystem boundaries#14
Merged
Conversation
wagoodman
force-pushed
the
fix-move-to-copy
branch
2 times, most recently
from
43f33f1 to
1ad6a8d
Compare
wagoodman
changed the title
wagoodman
force-pushed
the
fix-move-to-copy
branch
from
1ad6a8d to
3987377
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
fix-move-to-copy
branch
from
3987377 to
ec3d3e4
Compare
wagoodman
changed the title
willmurphyscode
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported on slack that using
binnydidn't work and failed with an errorinvalid cross-device linkThis is because
os.Renamewas used when moving the temp directory that contains a new tool installation to the final destination within the store. I attempting using a copy first instead of a move, however, if the binary in question is still in use, then you will see an errortext in busy. Instead the change is to use a tmp directory path to be within the store path itself, so thatos.Renamecan still be used.CC: @brian-ebarb