feat: use v2 API if available#59
Merged
Merged
Conversation
Contributor
Author
|
Please review carefully, this was written by an idiot |
robcresswell
force-pushed
the
feat/use-v2-api
branch
2 times, most recently
from
45f4d79 to
ed76429
Compare
bradleyjones
requested changes
Aug 18, 2023
robcresswell
force-pushed
the
feat/use-v2-api
branch
from
ed76429 to
9c2ba25
Compare
bradleyjones
requested changes
Aug 21, 2023
This patch adds support for using the new v2 API by default, and falling back to v1. This shouldn't be a breaking change until we remove support for the v1 API Signed-off-by: Rob Cresswell <robcresswell@users.noreply.github.com>
robcresswell
force-pushed
the
feat/use-v2-api
branch
from
9c2ba25 to
f65499b
Compare
bradleyjones
approved these changes
Aug 21, 2023
Member
bradleyjones
left a comment
bradleyjones
left a comment
There was a problem hiding this comment.
Tested against Enterprise 4.8 and latest RC and all working good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for using the new v2 API by default, and falling back to v1. This shouldn't be a breaking change until we remove support for the v1 API