Skip to content

Conversation

@witchcraze
Copy link
Contributor

Description

add envoy classifier

$ go run cmd/syft/main.go -q envoyproxy/envoy:v1.33-latest | grep "envoy"
envoy                1.33.14                                  binary

$ docker run -it --rm --entrypoint /usr/local/bin/envoy istio/proxyv2:1.26.8 --version

/usr/local/bin/envoy  version: 51e3efe76b3f7d4f81ad159701829f8a97f81600/1.34.13-dev/Clean/RELEASE/BoringSSL

$ go run cmd/syft/main.go -q istio/proxyv2:1.26.8 | grep "envoy "
envoy                                             1.34.13-dev                            binary
github.com/envoyproxy/go-control-plane/envoy      v1.32.5-0.20250411033633-fceb350c06ca  go-module
$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/envoy
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/envoy/1.36.4/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.36.4/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.34.5/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.34.5/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.28.7/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.28.7/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.22.11/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.22.11/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.20.7/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.20.7/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.18.6/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.18.6/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.14.3/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.14.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.11.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.11.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.6.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "envoy/1.6.0/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (0.59s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.36.4/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.34.5/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.28.7/linux-amd64 (0.07s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.22.11/linux-amd64 (0.07s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.20.7/linux-amd64 (0.07s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.18.6/linux-amd64 (0.07s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.14.3/linux-amd64 (0.06s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.11.0/linux-amd64 (0.05s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.6.0/linux-amd64 (0.04s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       0.612s

$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/envoy -must-use-original-binaries
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/envoy/1.36.4/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.36.4/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.34.5/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.34.5/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.28.7/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.28.7/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.22.11/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.22.11/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.20.7/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.20.7/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.18.6/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.18.6/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.14.3/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.14.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.11.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.11.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/envoy/1.6.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "envoy/1.6.0/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (1.00s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.36.4/linux-amd64 (0.04s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.34.5/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.28.7/linux-amd64 (0.12s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.22.11/linux-amd64 (0.17s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.20.7/linux-amd64 (0.11s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.18.6/linux-amd64 (0.14s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.14.3/linux-amd64 (0.17s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.11.0/linux-amd64 (0.11s)
    --- PASS: Test_Cataloger_PositiveCases/envoy/1.6.0/linux-amd64 (0.07s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       1.028s

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (please discuss with the team first; Syft is 1.0 software and we won't accept breaking changes without going to 2.0)
  • Documentation (updates the documentation)
  • Chore (improve the developer experience, fix a test flake, etc, without changing the visible behavior of Syft)
  • Performance (make Syft run faster or use less memory, without changing visible behavior much)

Checklist

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Issue references

Fixes #4506

Signed-off-by: witchcraze <witchcraze@gmail.com>
Signed-off-by: witchcraze <witchcraze@gmail.com>
@witchcraze witchcraze mentioned this pull request Jan 6, 2026
9 tasks
@wagoodman wagoodman merged commit 81dd955 into anchore:main Jan 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catalog envoy binary

2 participants