update istio classifier by witchcraze · Pull Request #4645 · anchore/syft

witchcraze · 2026-03-01T13:13:59Z

Description

update grafana classifier to support alpha, beta, rc, dev version.

$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/istio
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.3.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.1.17/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.1.17/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (3.17s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64 (0.48s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64 (0.78s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64 (0.52s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64 (0.10s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64 (0.09s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64 (0.11s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64 (0.09s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64 (0.11s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64 (0.18s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64 (0.19s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64 (0.06s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64 (0.24s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64 (0.06s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       3.191s

$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/istio -must-use-original-binaries
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.3.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.1.17/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.1.17/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (34.86s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64 (3.06s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64 (3.07s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64 (3.06s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64 (2.74s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64 (3.42s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64 (4.72s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64 (1.46s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64 (4.44s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64 (0.76s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64 (0.77s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64 (0.75s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64 (0.73s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64 (1.56s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64 (2.61s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64 (1.72s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       34.879s

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (please discuss with the team first; Syft is 1.0 software and we won't accept breaking changes without going to 2.0)
Documentation (updates the documentation)
Chore (improve the developer experience, fix a test flake, etc, without changing the visible behavior of Syft)
Performance (make Syft run faster or use less memory, without changing visible behavior much)

Checklist

I have added unit tests that cover changed behavior
I have tested my code in common scenarios and confirmed there are no regressions
I have added comments to my code, particularly in hard-to-understand sections

Issue references

Fixes #4546

witchcraze · 2026-03-13T06:51:36Z

To solve conflict (need to download binary and make snippet again), update capture-snippet.sh will be required in #4662

witchcraze · 2026-03-29T14:03:51Z

Update files to solve conflict.
Update download_from_image.go to support single manifest. (in this case, 1.10-dev)

$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/istio
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.3.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-discovery/1.1.17/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64
    snippet_or_binary.go:50: using snippet for "istio_pilot-agent/1.1.17/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (1.16s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64 (0.11s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64 (0.10s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64 (0.10s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64 (0.10s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64 (0.10s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64 (0.09s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64 (0.05s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64 (0.05s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64 (0.05s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64 (0.05s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64 (0.06s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64 (0.08s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64 (0.06s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       1.179s

$ go test -v ./syft/pkg/cataloger/binary -run Test_Cataloger_PositiveCases/istio -must-use-original-binaries
=== RUN   Test_Cataloger_PositiveCases
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.3.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-discovery/1.1.17/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-alpha.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-beta.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.29.0-rc.3/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.26.8/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.10-dev/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.8.0/linux-amd64"
=== RUN   Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64
    snippet_or_binary.go:62: forcing the use of the original binary for "istio_pilot-agent/1.1.17/linux-amd64"
--- PASS: Test_Cataloger_PositiveCases (34.01s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-alpha.0/linux-amd64 (3.07s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-beta.0/linux-amd64 (2.98s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.29.0-rc.3/linux-amd64 (3.03s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.26.8/linux-amd64 (2.66s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.10-dev/linux-amd64 (3.27s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.8.0/linux-amd64 (4.75s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.3.8/linux-amd64 (1.43s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-discovery/1.1.17/linux-amd64 (4.26s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-alpha.0/linux-amd64 (0.74s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-beta.0/linux-amd64 (0.75s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.29.0-rc.3/linux-amd64 (0.73s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.26.8/linux-amd64 (0.72s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.10-dev/linux-amd64 (1.52s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.8.0/linux-amd64 (2.46s)
    --- PASS: Test_Cataloger_PositiveCases/istio_pilot-agent/1.1.17/linux-amd64 (1.66s)
PASS
ok      github.com/anchore/syft/syft/pkg/cataloger/binary       34.027s

Signed-off-by: witchcraze <witchcraze@gmail.com>

update download_from_image.go to support single manifest Signed-off-by: witchcraze <witchcraze@gmail.com>

Signed-off-by: witchcraze <witchcraze@gmail.com>

witchcraze · 2026-04-12T09:46:27Z

Since #4753 fixed download_from_image.go, I dropped my change.

kzantow

LGTM; thanks @witchcraze!

witchcraze · 2026-04-12T15:40:54Z

Thank you!

witchcraze force-pushed the 4546_update-istio-binary-classifier branch from e20af60 to 0638069 Compare March 29, 2026 13:42

witchcraze added 4 commits April 12, 2026 18:27

update istio classifier

9c9490a

Signed-off-by: witchcraze <witchcraze@gmail.com>

solve conflict

8f6bf15

update download_from_image.go to support single manifest Signed-off-by: witchcraze <witchcraze@gmail.com>

remove snippets in old test directory

930895b

Signed-off-by: witchcraze <witchcraze@gmail.com>

remove change of download_from_image.go

7105e7e

Signed-off-by: witchcraze <witchcraze@gmail.com>

witchcraze force-pushed the 4546_update-istio-binary-classifier branch from c95bf5a to 7105e7e Compare April 12, 2026 09:42

kzantow approved these changes Apr 12, 2026

View reviewed changes

kzantow merged commit e420322 into anchore:main Apr 12, 2026
14 checks passed

witchcraze deleted the 4546_update-istio-binary-classifier branch April 12, 2026 15:40

BrewTestBot mentioned this pull request Apr 22, 2026

syft 1.43.0 Homebrew/homebrew-core#278928

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update istio classifier#4645

update istio classifier#4645
kzantow merged 4 commits intoanchore:mainfrom
witchcraze:4546_update-istio-binary-classifier

witchcraze commented Mar 1, 2026

Uh oh!

witchcraze commented Mar 13, 2026

Uh oh!

witchcraze commented Mar 29, 2026

Uh oh!

witchcraze commented Apr 12, 2026

Uh oh!

kzantow left a comment

Uh oh!

Uh oh!

witchcraze commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

witchcraze commented Mar 1, 2026

Description

Type of change

Checklist

Issue references

Uh oh!

witchcraze commented Mar 13, 2026

Uh oh!

witchcraze commented Mar 29, 2026

Uh oh!

witchcraze commented Apr 12, 2026

Uh oh!

kzantow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

witchcraze commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants