add aws-lc classifier and update openssl classifier#4882
Conversation
Signed-off-by: witchcraze <witchcraze@gmail.com>
| }, | ||
| { | ||
| Class: "aws-lc-binary", | ||
| FileGlob: "**/openssl", |
There was a problem hiding this comment.
Instead of this, you could use the same pattern the java matcher does which only requires reading the bytes one time using the branching evidence matcher, which basically matches the first thing so in your case here, put the aws-lc match first and it won't fall through to the openssl default and it avoids duplicating logic by adding negative matching.
There was a problem hiding this comment.
Thank you for your review. That makes sense.
I updated to use BranchingEvidenceMatcher.
Signed-off-by: witchcraze <witchcraze@gmail.com>
| CPEs: singleCPE("cpe:2.3:a:amazon:aws_libcrypto:*:*:*:*:*:*:*:*", cpe.NVDDictionaryLookupSource), | ||
| }, | ||
| { | ||
| Class: "openssl-binary-openssl", |
There was a problem hiding this comment.
I forgot about the naming, I think this one should be class "openssl-binary" like the parent so these findings don't change.
There was a problem hiding this comment.
Thank you for your review.
I updated class name of default openssl.
Signed-off-by: witchcraze <witchcraze@gmail.com>
Signed-off-by: witchcraze <witchcraze@gmail.com>
Sorry, I run 'go generate ./internal/capabilities' locally and committed the changes |
| purl: pkg:generic/openssl | ||
| cpes: | ||
| - cpe:2.3:a:openssl:openssl:*:*:*:*:*:*:*:* | ||
| name: "" |
There was a problem hiding this comment.
this is unfortunate. for the binary cataloger this might be useful to have some override
There was a problem hiding this comment.
Thank you.
I updated binaryClassifierOverrides. (Sorry, I did not know this override system)
Signed-off-by: witchcraze <witchcraze@gmail.com>
|
Thanks for the update @witchcraze and sorry for the back-and-forth 🙏 |
Description
This PR adds aws-lc classifier, and updates openssl classifier to exclude aws-lc.
From NVD data, CPE
2.3:a:amazon:aws_libcryptois used.https://nvd.nist.gov/vuln/detail/CVE-2026-3336
Now, Syft detects aws-lc as openssl, and then Grype detects many false openssl vuluneravility,
This PR solves this issue, and proper vulinerability will be detected by Grype.
Type of change
Checklist
Issue references
Fixes #4539