chore: configure and run ruff format#469
Merged
willmurphyscode merged 1 commit intomainfrom Feb 12, 2025
Merged
Conversation
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
kzantow
approved these changes
Feb 12, 2025
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
I'm definitely not the best to review Python, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a make target
make formatthat runsruff format src tests, and call it during pre-commit. The rest of the diff is auto-generated, with the exception that ruff format put an existingtype: ignore[attr-defined]on the wrong line when splitting up a line that was too long.Most of the auto generated diff is line length changes. I'm happy to move the line length configured in
tool.ruff.line-lengthin the pyproject.toml to try to reduce the diff size, but for a first draft I just left it what it was.