#159082379 A User Should Be Able To Create article #22
Conversation
abulojoshua1
force-pushed
the
ft-create-user-articles-159082379
branch
2 times, most recently
from
474b7a9 to
22c8987
Compare
abulojoshua1
requested review from
geofrocker,
lytes20 and
ssewilliam
and removed request for
lytes20
authors/apps/articles/renderers.py
Outdated
| pass | ||
| # As mentioned about, we will let the default JSONRenderer handle | ||
| # rendering errors. | ||
| # return super(UserJSONRenderer, self).render(data) |
There was a problem hiding this comment.
- Is this Commented code
- I think you should return the line
return super(ArticlesJSONRenderer, self).render(data)
I think what that does is return the actual error if the class'srender()itself has an error
There was a problem hiding this comment.
Thanks for Identifying that @ssewilliam, Sharp eye there! I will work on it asap.
authors/apps/articles/models.py
Outdated
| updatedAt = models.DateTimeField(auto_now=True) | ||
|
|
||
| # This makes identifies the owner of the publication | ||
| user = models.ForeignKey(User, on_delete=models.CASCADE) |
There was a problem hiding this comment.
- You could have also called this
userasuser_id
There was a problem hiding this comment.
Ok, I will work on that as soon as possible.
| self.article_to_create = { | ||
| "article": { | ||
| "title": "hahahhaha hahaha hahah ahhah", | ||
| "body": "<p>this is a body that is here hahahhahaha\n <p", |
There was a problem hiding this comment.
@abulojoshua1
Can you clarify on why you are passing in raw HTML here
There was a problem hiding this comment.
i think this is some data to be used in the test and it should be okay to write some raw html @ssewilliam , maybe @abulojoshua1 could also say something
There was a problem hiding this comment.
I would like to mimic the presence on an article that has HTML attributes like Bolding, paragraphs, etc in an article body. But as for now, that for tests.
abulojoshua1
force-pushed
the
ft-create-user-articles-159082379
branch
from
22c8987 to
076f9ce
Compare
authors/apps/articles/models.py
Outdated
| published = models.BooleanField(default=False) | ||
|
|
||
| # this takes the time stamp of when the article was made | ||
| createdAt = models.DateTimeField(auto_now_add=True) |
There was a problem hiding this comment.
use underscores for variable naming
abulojoshua1
force-pushed
the
ft-create-user-articles-159082379
branch
2 times, most recently
from
67e45c4 to
864a4ce
Compare
abulojoshua1
force-pushed
the
ft-create-user-articles-159082379
branch
from
864a4ce to
31c48fa
Compare
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
/api/articles/{ "article": { "title": "THE ARTICLE TITLE", "body": "THE ARTICLE BODY", "description": "THE ARTICLE DESCRIPTION" } }Any background context you want to provide?
articles.What are the relevant pivotal tracker stories?