Skip to content

Conversation

@JoaRiski
Copy link
Contributor

Update readme
Add travis
Add tests
Fix a bug that occurs if order is None in sort_by_order

No refs

@JoaRiski JoaRiski requested a review from suutari-ai October 26, 2017 09:35
@JoaRiski JoaRiski force-pushed the fix-bugs branch 4 times, most recently from cbf6973 to e2868cd Compare October 26, 2017 09:46
Add travis, codecov and test configuration

No refs
Fix sort_by_order crashing if order is None
Add a test for this

No refs
@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@04aa9af). Click here to learn what that means.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   28.57%           
=========================================
  Files             ?        3           
  Lines             ?      133           
  Branches          ?        0           
=========================================
  Hits              ?       38           
  Misses            ?       95           
  Partials          ?        0
Impacted Files Coverage Δ
django_sorting_field_tests/test_utils.py 100% <100%> (ø)
django_sorting_field/utils.py 71.42% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04aa9af...00a920f. Read the comment docs.

Copy link
Member

@suutari-ai suutari-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Joa! 👍

@suutari-ai suutari-ai merged commit 7362ba3 into master Oct 26, 2017
@suutari-ai suutari-ai deleted the fix-bugs branch October 26, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants