Add path of the config file to Python path #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unneeded nargs=1 from config and output arguments, since those are simple single value arguments and it is more logical that the value is not parsed into a list.
There could be global sanitizers present at the path of the configuration file. Make sure that those are importable without setting the PYTHONPATH environment variable.
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 94.18% 93.84% -0.34%
==========================================
Files 24 24
Lines 842 845 +3
==========================================
Hits 793 793
- Misses 49 52 +3
Continue to review full report at Codecov.
|
ehaivala
approved these changes
Jun 20, 2018
Contributor
ehaivala
left a comment
ehaivala
left a comment
There was a problem hiding this comment.
Makes sense. Great stuff 👍
Contributor
|
And so the coverage gods gently wept in silence... 😜 |
Member
Author
You're right. This stuff is supposed to be tested. I did some improvements to the test coverage in PR #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be global sanitizers present at the path of the configuration
file. Make sure that those are importable without setting the PYTHONPATH
environment variable.