Merged
Conversation
endpoint get historial turnos paciente
fix cambio carpeta sobreturnos
mobile: Handler error en login no profesional.
se modifica job de Pecas Consolidado
Carpetas job - PR limpio
CITAS - Punto de Inicio - Editar número de carpeta
Get historial paciente - mejora
…es de un paciente
liquid36
reviewed
Aug 6, 2018
| { key: 'solicitud', title: 'Registrar solicitud', type: 'boolean' }, | ||
| { key: 'autocitado', title: 'Registrar Autocitación', type: 'boolean' }, | ||
| { key: 'darTurnos', title: 'Dar turnos desde punto inicio', type: 'boolean' }, | ||
| { key: 'puedeEditarCarpeta', title: 'Editar número de carpeta', type: 'boolean' } |
Contributor
There was a problem hiding this comment.
La palabra 'puede' en el nombre de un permiso es redundante.
liquid36
reviewed
Aug 6, 2018
| } | ||
|
|
||
| ]; | ||
| let data2 = await agenda.aggregate(pipelineTurno).exec(); |
Contributor
There was a problem hiding this comment.
Mejora: Se puede hacer una sola query de mongo para obtener el listado de turnos y sobreturnos.
liquid36
reviewed
Aug 6, 2018
| let data2 = await agenda.aggregate(pipelineTurno).exec(); | ||
| let sobreturnos = await agenda.aggregate(pipelineSobreturno).exec(); | ||
| data2 = data2.concat(sobreturnos); | ||
| data2.forEach(elem => { |
Contributor
There was a problem hiding this comment.
Mejora: para evitar este for se podría usar el $project de mongo.
liquid36
reviewed
Aug 6, 2018
| { | ||
| "name": "api", | ||
| "version": "3.3.2", | ||
| "version": "3.4.0", |
Contributor
There was a problem hiding this comment.
Hay que jugar el 34 en la lotería. XD
liquid36
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funcionalidades ingresadas
Requiere actualizaciones en la base de datos