Skip to content

fix: import errors#16

Merged
andi23rosca merged 17 commits intoandi23rosca:masterfrom
zentered:fix/import-errors
Apr 3, 2023
Merged

fix: import errors#16
andi23rosca merged 17 commits intoandi23rosca:masterfrom
zentered:fix/import-errors

Conversation

@PatrickHeneise
Copy link
Copy Markdown
Contributor

Closes #12
Closes #13

This fixes the current import issues with solid-start. I took the liberty and added some tooling around it for publishing, auto formatting etc.

@koolskateguy89
Copy link
Copy Markdown

Just wondering why you'd make a Prettier config that is different from what the current styling of the source code? As a result, the diff is mostly style changes - making it a lot more tedious for the library author to review the changes

@PatrickHeneise
Copy link
Copy Markdown
Contributor Author

Just wondering why you'd make a Prettier config that is different from what the current styling of the source code? As a result, the diff is mostly style changes - making it a lot more tedious for the library author to review the changes

you're right; I copied over my default set. Will adjust the config.

@demizer
Copy link
Copy Markdown

demizer commented Apr 3, 2023

Hi,

Just getting back into webdev after many years away, but it still seems this change still does not work.

npm is not installing the needed files:

image

An unhandled error occured: Error: Failed to resolve entry for package "@zentered/solid-markdown". The package may have incorrect main/module/exports specified in its package.json.
    at packageEntryFailure (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:23266:11)
    at resolvePackageEntry (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:23263:5)
    at tryNodeResolve (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:23000:20)
    at Context.resolveId (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:22762:28)
    at file:///home/demizer/code/websites/masterof.one/node_modules/vite-plugin-inspect/dist/index.mjs:719:32
    at plugin2.<computed> (file:///home/demizer/code/websites/masterof.one/node_modules/vite-plugin-inspect/dist/index.mjs:682:16)
    at Object.resolveId (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:43314:46)
    at async TransformContext.resolve (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:43043:23)
    at async normalizeUrl (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:41370:34)
    at async TransformContext.transform (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:41512:47)
    at async file:///home/demizer/code/websites/masterof.one/node_modules/vite-plugin-inspect/dist/index.mjs:692:23
    at async Object.transform (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:43387:30)
    at async loadAndTransform (file:///home/demizer/code/websites/masterof.one/node_modules/vite/dist/node/chunks/dep-79892de8.js:41105:29)

Thanks!

@PatrickHeneise
Copy link
Copy Markdown
Contributor Author

@demizer note: I published this in our org-scope as a temporary fix. Once the import errors are resolved I'll deprecate our package in favor of this one here.

When I run npm install @zentered/solid-markdown in a fresh folder, I get everything that's needed:

Screenshot 2023-04-03 at 3 18 45 PM

Not sure what went wrong with your install.

@andi23rosca andi23rosca merged commit 5e171bf into andi23rosca:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to resolve entry for package "solid-markdown" SolidStart SSR/SSG

4 participants