Merged
Conversation
Contributor
high1
commented
Oct 31, 2021
high1
commented
- used webpack to build the package, since rollup has issues with debug, upon which micromark depends on
- built package with babel, definitions created with typescript compiler itself
- updated packages to their latest versions
- package could not be used when built by rollup, micromark depends on debug and rollup has a long standing issue with debug - created webpack configuration - added babel configuration - use ts-loader to extract type definitions - updated all packages - removed pnpm lock file
- used @babel/preset-typescript to compile the whole project with babel - used TypeScript compiler to build definitions only - updated babel configuration - recreated package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.