Changing the Battery Notes battery sensor name unexpectedly sets it to not-visible

[chriswood1001]

System Health details

Version: 2024.2.0
Source: Container
Channel: Stable

I'm unable to find the "System Health" page on my Docker installation with those instructions. I've submitted a separate ticket to HA regarding this.

Checklist

• I have added battery_notes: to my configuration.yaml and restarted.
• I have read the FAQ's.
• I have enabled debug logging for my installation.
• I have filled out the issue template to the best of my ability.
• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of any previous issues..

Describe the issue

Set the Battery Notes battery sensor to the same entity_id of the original devices battery sensor automatically hides both battery sensors when hide_battery: true. My goal is to rename my old/original battery sensors (e.g append _original) and hide them, then make the Battery Notes sensor match the original sensor ID. This means existing automations or dashboards don't need to be edited while allowing Battery Notes to become my new reference.

Reproduction steps

1. Enable hide_battery: true in your configuration.yaml and restart HA.
2. View a battery operated device and notice the devices original battery is hidden (expected) and Battery Notes battery sensor (with the various attributes) is displayed (expected).
3. Edit the entity_id of the original device battery sensor to something like: sensor.livingroom_temperature_battery_original
4. Edit the entity_id of the Battery Notes sensor to match the original devices sensor id: sensor.livingroom_temperature_battery
5. Observe that the Battery Notes sensor is now marked as (Hidden) with no ability to unhide it. The settings reads, "/!\ Hidden by Integration".

I've also tried performing steps 3 and 4 while hide_battery:false, and then set hide_battery:true; however, the issue persists on HA restart.
...

Debug logs

GitHub error: Issue templates and forms are currently unavailable. Please try again later.

Diagnostics dump

No response

[andrew-codechimp]

Changing entity id's on the original battery is probably always going to do something odd but I'll have a look and try and handle it better, at least not hiding the battery_notes_plus entity.

[hellcry37]

Why would you rename old/original battery sensors (e.g append _original) and then rename the battery plus one to _battery? I mean I understand that you dont want to edit your automations but isn't a bit crazy to do this?
I mean you work disable and rename original entities and to rename all the stuff in this integration to mach original names ... but you do not rename sensors in automations?

You can do this with VSCode in literary 2 minutes and a HA restart!

So basically you work twice as much, just not to work on changing sensors in automations ...

[andrew-codechimp]

This is a bit of a niche use case I agree but a lot of people don't like editing yaml so I should be handling this better.

Looking at the code I can see this scenario sets up a horrible circular reference within battery_plus, but I've found a way to detect the original entity id changes and make the appropriate changes.

I'll not be able to fix existing ones you've renamed but if you delete the battery note for that device and re-add it should put things back to normal.

Expect a fix in beta next week, subject to life/day job.

[andrew-codechimp]

This is now in beta version 2.0.11.