Fixes and tweaks to Merbench #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement clickable column headers with sort indicators, sorting utilities, and state management. - Headers now support ascending/descending sort by model name, success rate, cost, duration, tokens, runs, and provider with visual feedback.
|
✅ Preview deployment ready! 📋 PR #28 has been deployed to: https://andrewginns.github.io/ Built from commit: 4fd8dd0 This preview will be updated automatically when you push new commits to this PR. |
|
✅ Preview deployment ready! 📋 PR #28 has been deployed to: https://andrewginns.github.io/ Built from commit: 3b2c106 This preview will be updated automatically when you push new commits to this PR. |
|
🚀 Production deployment ready! 📋 PR #28 has been deployed to production: https://148a543a.andrewginns.pages.dev Built from commit: c440c9d Your changes are now live on the production site! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactive sorting functionality to the Merbench leaderboard, improves the UI for cost and success rate display, and refines filter and event handling for a better user experience.
Problem:
Previously, the Merbench leaderboard table was static: users could not sort models by cost, success rate, or other columns. Additionally, filter events did not trigger updates as expected, and the cost and success rate indicators lacked visual clarity.
Solution:
Unlocks:
Detailed breakdown of changes:
src/scripts/merbench-sorting.ts: Implements the sorting logic and DOM manipulation for the leaderboard.src/components/merbench/LeaderboardTable.astro: Added sortable headers, progress bars for cost, and improved accessibility.src/lib/merbench.ts: Added sorting utilities and refactored the leaderboard update logic.src/scripts/merbench-filters.tsandsrc/scripts/merbench-init-csp.ts: Integrated the new sorting and leaderboard update logic.src/components/merbench/CombinedFilters.astro: Now dispatches change events on all checkboxes, ensuring accurate UI updates.public/_headersto support the new functionality.