Fix broken demo images — source.unsplash.com/random is deprecated (503)#30
Closed
kiluazen wants to merge 1 commit into
Closed
Fix broken demo images — source.unsplash.com/random is deprecated (503)#30kiluazen wants to merge 1 commit into
kiluazen wants to merge 1 commit into
Conversation
The source.unsplash.com/random endpoint was deprecated by Unsplash in mid-2024 and now returns 503, so the two <img> tags in demo.html render broken on any visit. Replace both with specific images.unsplash.com photo URLs pinned with fixed dimensions.
4 tasks
Owner
|
Fixed with #31. I appreciate you flagging this, and hope you enjoy okcss! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the two
<img>tags indemo.html(L187, L196) still hotlinkhttps://source.unsplash.com/random/400x300. Unsplash deprecated thesource.unsplash.com/randomendpoint in mid-2024 and the endpoint now 503s, so anyone loading the demo currently sees broken image tiles where the Media section's examples are supposed to render.This PR swaps both to specific, permanent
images.unsplash.comphoto URLs pinned to 400×300. I also updatedalttext to describe each photo instead of saying "random placeholder image."Zero JS/CSS changes. Minimal two-line diff.
For context on the endpoint change: https://help.unsplash.com/en/articles/8656599-unsplash-source-is-deprecated
If you'd rather ship local assets instead of hotlinking, I wrote a small CLI for exactly that:
tteg—uv tool install tteg; tteg save "office" ./demo/img --width 400 --height 300. Repo: https://github.com/kiluazen/tteg. Happy to push a follow-up PR that swaps to local files if you prefer.Thanks for okcss!