Skip to content

Improvements to unit tests & docstrings#6

Merged
andrewjlock merged 7 commits into
mainfrom
dev
May 25, 2026
Merged

Improvements to unit tests & docstrings#6
andrewjlock merged 7 commits into
mainfrom
dev

Conversation

@andrewjlock

Copy link
Copy Markdown
Owner

Primarily just improvements to tests (suppressing warnings, removing needless Jax skip) and updating docs & docstrings to match source code.

Small change to pyproj input parsing to remove numpy deprecation warning. No change to functionality.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test coverage and documentation, and also adjusts a few core math utilities (refraction handling and FRD velocity projection) to improve backend compatibility and reduce warnings.

Changes:

  • Added/expanded unit tests (including new ray refraction tests) and improved JAX/backend handling in rotation tests.
  • Updated refraction behavior and Ray.correct_refraction() API to support direction modes.
  • Adjusted project_velocity_to_az_el() to return az/el/range rates and updated its docstring accordingly; added global pytest warning filters.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/core/test_ray.py Adds a new unit test covering Ray.correct_refraction() modes and invalid mode handling.
tests/core/test_functs.py Removes the JAX skip by converting rotations to the active backend; expands coverage for refraction and velocity-rate projection.
src/astrix/spatial/ray.py Extends Ray.correct_refraction() with a mode parameter and adjusts correction application logic.
src/astrix/spatial/location.py Docstring wording updates to better reflect Point usage patterns.
src/astrix/plots/plot3d.py Tweaks legend font size for better readability.
src/astrix/functs.py Alters pyproj input parsing to avoid warnings; updates NED rotation docs; clips refraction elevation inputs; changes velocity-rate projection outputs/shape.
pyproject.toml Adds pytest filterwarnings configuration to suppress “Force converting …” warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/astrix/functs.py
Comment thread src/astrix/functs.py
Comment thread src/astrix/functs.py Outdated
Comment thread src/astrix/spatial/ray.py Outdated
andrewjlock and others added 4 commits May 25, 2026 10:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@andrewjlock andrewjlock merged commit 49589bc into main May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants