This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Delete HTTPS instead of SSH key password on error #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
added a commit
that referenced
this pull request
Aug 27, 2020
* develop: Delete HTTPS instead of SSH key password on error (#1060) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
added a commit
that referenced
this pull request
Aug 27, 2020
* develop: Delete HTTPS instead of SSH key password on error (#1060)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Since #995 (more specifically this line), we are removing the SSH key passphrase instead of the HTTPS password. This is just plain wrong and appears to have slipped in during a merge.
💡 Motivation and Context
💚 How did you test it?
Verified that the stored HTTPS password is removed when it causes an error due to failed authentication.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs