Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Delete HTTPS instead of SSH key password on error #1060

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Delete HTTPS instead of SSH key password on error #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a111cf5
Delete HTTPS instead of SSH key password on error
fmeum Aug 27, 2020
bccce9e
Add CHANGELOG.md entry
fmeum Aug 27, 2020
2f3a204
Merge branch 'develop' into bug/delete_https_password_on_error
FabianHenneke Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ All notable changes to this project will be documented in this file.

- Password creation UI will scroll if it does not fit on the screen
- Git server protocol and authentication mode are only updated when explicitly saved
- Delete stored HTTPS password on connection errors (such as failed authentication)

## [1.11.2] - 2020-08-24

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ abstract class GitOperation(gitDir: File, internal val callingActivity: Fragment
open fun onError(err: Exception) {
// Clear various auth related fields on failure
callingActivity.getEncryptedPrefs("git_operation").edit {
remove(PreferenceKeys.SSH_KEY_LOCAL_PASSPHRASE)
remove(PreferenceKeys.HTTPS_PASSWORD)
}
callingActivity.sharedPrefs.edit { remove(PreferenceKeys.SSH_OPENKEYSTORE_KEYID) }
d(err)
Expand Down