Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

Backports #1062, strips the -free version suffix.

FabianHenneke and others added 3 commits August 27, 2020 17:36
* Remember HTTPS password throughout a sync operation

* Add CHANGELOG.md entry

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit cba0bc2)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis merged commit 7b4792d into android-password-store:release Aug 27, 2020
@fmeum
Copy link
Member

fmeum commented Aug 27, 2020

Thanks, will update the F-Droid PR once the release artifacts have been generated.

@msfjarvis msfjarvis deleted the release branch August 27, 2020 13:31
@fmeum
Copy link
Member

fmeum commented Aug 27, 2020

The release is in a draft status now, are you doing the rest manually?

@msfjarvis
Copy link
Member Author

The release is in a draft status now, are you doing the rest manually?

The release is built as a draft by default so I can double check before everybody gets notified, I'm uploading to Play Store right now.

@fmeum
Copy link
Member

fmeum commented Aug 27, 2020

The verification of our release builds fails with an error message. Not sure what's up there, it used to work and the CI workflow hasn't changed, right?

2020-08-27 15:52:10,362 WARNING: Ignoring META-INF/MANIFEST.MF from unsigned/dev.msfjarvis.aps_11130.apk
DOES NOT VERIFY
ERROR: JAR signer CERT.RSA: JAR signature META-INF/CERT.SF indicates the APK is signed using APK Signature Scheme v2 but no such signature was found. Signature stripped?
2020-08-27 15:52:11,498 ERROR: 
/tmp/tmp2h845_px/sigcp_dev.msfjarvis.aps_11130.apk: 
2020-08-27 15:52:11,498 INFO: ...NOT verified - /tmp/tmp2h845_px/sigcp_dev.msfjarvis.aps_11130.apk
I: Using Apktool 2.4.0-dirty on dev.msfjarvis.aps_11130.binary.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/fhenneke/.local/share/apktool/framework/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
I: Using Apktool 2.4.0-dirty on sigcp_dev.msfjarvis.aps_11130.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/fhenneke/.local/share/apktool/framework/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
2020-08-27 15:52:24,664 DEBUG: > diff -r /tmp/tmp2h845_px/unsigned_binaries_dev.msfjarvis.aps_11130.binary /tmp/tmp2h845_px/_tmp_tmp2h845_px_sigcp_dev.msfjarvis.aps_11130
2020-08-27 15:52:24,976 DEBUG: removing unsigned/dev.msfjarvis.aps_11130.apk
2020-08-27 15:52:24,979 DEBUG: removing unsigned/binaries/dev.msfjarvis.aps_11130.binary.apk
2020-08-27 15:52:25,273 ERROR: Could not build app dev.msfjarvis.aps: compared built binary to supplied reference binary but failed
==== detail begin ====
Unexpected diff output:
diff -r /tmp/tmp2h845_px/unsigned_binaries_dev.msfjarvis.aps_11130.binary/apktool/apktool.yml /tmp/tmp2h845_px/_tmp_tmp2h845_px_sigcp_dev.msfjarvis.aps_11130/apktool/apktool.yml
2c2
< apkFileName: dev.msfjarvis.aps_11130.binary.apk
---
> apkFileName: sigcp_dev.msfjarvis.aps_11130.apk
==== detail end ====

@fmeum
Copy link
Member

fmeum commented Aug 27, 2020

@msfjarvis
Copy link
Member Author

Don't really know what's up with this, the CI workflow is definitely the same and we've not had any major AGP bumps that'd change it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants