Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@fmeum
Copy link
Member

@fmeum fmeum commented Aug 27, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Remember the HTTPS password throughout a sync operation.

💡 Motivation and Context

The current state could be viewed as having just a UI issue (the second prompt is marked with the "Wrong passphrase" error), but since it counts as a retry in our PasswordFinder implementation, this also removes the stored passphrase, which is a bit more of a nuisance. I'm labeling this as backport for that reason, but am not a 100% sure.

💚 How did you test it?

Sync operations succeed with only a single password prompt.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

msfjarvis
msfjarvis previously approved these changes Aug 27, 2020
@msfjarvis
Copy link
Member

Was hoping to avoid a v1.11.3 but that's certainly not happening now. Will queue backports and a release tonight. Anything special that needs to go in for F-Droid? Now's the time.

* develop:
  Delete HTTPS instead of SSH key password on error (#1060)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@fmeum
Copy link
Member Author

fmeum commented Aug 27, 2020

Was hoping to avoid a v1.11.3 but that's certainly not happening now. Will queue backports and a release tonight. Anything special that needs to go in for F-Droid? Now's the time.

Getting rid of the version name suffix would help, I don't think anything else is needed at this time.

@fmeum fmeum requested a review from msfjarvis August 27, 2020 10:13
@msfjarvis msfjarvis merged commit cba0bc2 into develop Aug 27, 2020
@msfjarvis msfjarvis deleted the bug/remember_https_password_on_sync branch August 27, 2020 10:13
@fmeum
Copy link
Member Author

fmeum commented Aug 27, 2020

@msfjarvis Could you also test password authentication a bit more before the release? I used https://try.gitea.io for that purpose.

@msfjarvis
Copy link
Member

@msfjarvis Could you also test password authentication a bit more before the release? I used https://try.gitea.io for that purpose.

Yeah I'll test it when I do the backports.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants