Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@fmeum
Copy link
Member

@fmeum fmeum commented Apr 6, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Android Oreo lacks the Autofill compatibility mode for browsers, which
means that browsers without explicit Android support will not trigger
Autofill events on web sites.

💡 Motivation and Context

Fixes #1369.

💚 How did you test it?

About to try this in an emulator.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

Android Oreo lacks the Autofill compatibility mode for browsers, which
means that browsers without explicit Android support will not trigger
Autofill events on web sites.
@fmeum fmeum force-pushed the autofill-android-8 branch from 9cb1197 to 0dd0440 Compare April 6, 2021 06:34
@fmeum
Copy link
Member Author

fmeum commented Apr 6, 2021

@msfjarvis While trying this in the emulator with API level 27, I noticed that tapping Settings on the first onboarding screen (the one with the Let's go button) triggers the following crash:

java.lang.RuntimeException: Unable to start activity ComponentInfo{dev.msfjarvis.aps.debug/dev.msfjarvis.aps.ui.settings.SettingsActivity}: java.lang.IllegalStateException: Setting the checked value before the preference was attached isn't supported. Consider using `defaultValue` instead.
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
	at android.app.ActivityThread.-wrap11(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6494)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Caused by: java.lang.IllegalStateException: Setting the checked value before the preference was attached isn't supported. Consider using `defaultValue` instead.
	at de.Maxr1998.modernpreferences.preferences.TwoStatePreference.setChecked(TwoStatePreference.kt:30)
	at dev.msfjarvis.aps.ui.settings.GeneralSettings.provideSettings(GeneralSettings.kt:69)
	at dev.msfjarvis.aps.ui.settings.SettingsActivity.onCreate(SettingsActivity.kt:38)
	at android.app.Activity.performCreate(Activity.java:7009)
	at android.app.Activity.performCreate(Activity.java:7000)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)
	... 9 more

Copy link
Member

@msfjarvis msfjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msfjarvis
Copy link
Member

Filed a separate bug for the settings crash, will address it soon.

@msfjarvis msfjarvis added A-autofill Area: Autofill A-UI-UX Area: General UI/UX concerns labels Apr 6, 2021
@msfjarvis msfjarvis merged commit 474770c into develop Apr 6, 2021
@msfjarvis msfjarvis deleted the autofill-android-8 branch April 6, 2021 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-autofill Area: Autofill A-UI-UX Area: General UI/UX concerns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] No Autofill on Firefox or Chrome

3 participants