-
-
Notifications
You must be signed in to change notification settings - Fork 307
Replace Timber with logcat #1509
Conversation
|
@pt2121 do you want me to review this? Draft indicates you're still working on it but I don't see any action items in your PR description. |
|
@msfjarvis I finished it late last night and wanted to do more tests. There are probably a couple things I'd like to run by you tho - will let you know. |
|
@msfjarvis This is ready for review. One small thing I want to call out is I had to manually add tags in a couple places for standalone functions. |
|
LGTM, I just have one suggestion. Instead of writing What if we overload the |
I'd be down for it, @pt2121 can you add the extension to |
|
Yeah, will update. good idea |
|
Updated! |
Skrilltrax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the pull request @pt2121
📢 Type of change
📜 Description
💡 Motivation and Context
Fixes #1505
💚 How did you test it?
📝 Checklist
./gradlew spotlessApply🔮 Next steps
📸 Screenshots / GIFs